Skip to content

Update installation.md#6438

Merged
stevhliu merged 4 commits into
huggingface:mainfrom
Bhavay-2001:patch-3
Jan 16, 2024
Merged

Update installation.md#6438
stevhliu merged 4 commits into
huggingface:mainfrom
Bhavay-2001:patch-3

Conversation

@Bhavay-2001
Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #5712.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Bhavay-2001 Bhavay-2001 mentioned this pull request Jan 3, 2024
6 tasks
Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Comment thread docs/source/en/installation.md Outdated
<pt>
```bash
pip install diffusers["torch"] transformers
Note - PyTorch doesn't support Python 3.12 on Windows. Please use Python 3.11 instead.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be placed outside of the code block and preferably before it :)

Suggested change
Note - PyTorch doesn't support Python 3.12 on Windows. Please use Python 3.11 instead.
PyTorch only supports Python 3.8 - 3.11 on Windows.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stevhliu, actually @patrickvonplaten suggested to place it inside the the Pytorch framework placeholder. Should I place this before the Pytorch block?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what I meant is it should be outside of the bash code block but inside the <pt> one like this:

<pt>

PyTorch only supports Python 3.8 - 3.11 on Windows.

<code snippet here>

</pt>

@Bhavay-2001
Copy link
Copy Markdown
Contributor Author

Hi @patrickvonplaten, can you please review this? Thanks

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Bhavay-2001
Copy link
Copy Markdown
Contributor Author

Hi @stevhliu , can you please merge this into the main branch? Thanks

@stevhliu
Copy link
Copy Markdown
Member

Hi, we can merge once this comment is addressed :)

@Bhavay-2001
Copy link
Copy Markdown
Contributor Author

Sorry I missed that. I will complete this.

@Bhavay-2001
Copy link
Copy Markdown
Contributor Author

Hi @stevhliu, I have updated the file. Please check once.
Thanks

Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stevhliu stevhliu merged commit dd63168 into huggingface:main Jan 16, 2024
@Bhavay-2001 Bhavay-2001 deleted the patch-3 branch January 17, 2024 15:35
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* Update installation.md

* Update installation.md

* Update installation.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pip install --upgrade diffusers[torch] fails with Python 3.12 on Windows 11

3 participants